Discourage MATLAB users from calling collect #12103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. |
|
I wonder if it's worth making clear that in most situations there is no performance loss from dealing with iterators, unlike in Python where you do often want to collect if you are more concerned with CPU usage than memory. |
JeffBezanson
added a commit
that referenced
this pull request
Jul 29, 2015
Discourage MATLAB users from calling collect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first started with Julia, using iterable objects instead of arrays seemed a bit confusing and magical so I would frequently just convert them into full arrays. I thought it would be nice to provide some explicit encouragement to not do that for future new adopters.