prevent accidental shutdown->close pattern on exit #12180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently not. Also fully closing #11017 would require deleting the corresponding |
vtjnash
force-pushed
the
jn/stop_double_close_stream
branch
from
81be7fc to
72973d8
Compare
since julia finalizers were now calling uv_shutdown on all streams (including stdio), and the code to check the julia isopen status got deleted, this code now needs to ensure that the jl_close_uv function is a no-op for streams in shutdown. this was previously observed in gdb to result in a call to uv_close on all streams in the jl_atexit_hook libuv-walk.
vtjnash
force-pushed
the
jn/stop_double_close_stream
branch
from
72973d8 to
951c4d3
Compare
also call the julia close cleanup handler on the file pseudo-objects
vtjnash
added a commit
that referenced
this pull request
Jul 20, 2015
prevent accidental shutdown->close pattern on exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since julia finalizers were now calling uv_shutdown on all streams (including stdio), and the code to check the julia isopen status got deleted, this code now needs to ensure that the jl_close_uv function is a no-op for streams in shutdown. this was previously observed in gdb to result in a call to uv_close on all streams in the jl_atexit_hook libuv-walk.
i think this should help fix #11017