-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable running tests with multiple processes on Win64 #12257
Conversation
Not sure what's wrong yet, but it might be related to how we have the compiler download cached on appveyor - you're supposed to get a |
That's also my guess and the only possible explaination I have at this point is that the cache is hashed by the environment setup... |
@tkelman FWIW, I see the following error on all master builds and not on any PR's. Is this expected / related? On 32bit
On 64bit
|
That's expected, it just means it doesn't have the opposite bitness downloaded files - so far it hasn't been an issue? |
Do we not have any more reliable download sources? (after github removes the download page) |
I just moved a bunch of things to bintray. And we have our caching server which goes to s3. I can copy the relevant downloads over to bintray and adjust the url's, if you don't mind me pushing to this branch? |
Go ahead! That's the point of using a branch here. =) |
one remaining exception is for msys make which does not need to be downloaded on appveyor
The download address change doesn't seem to help =(. |
revert this later?
cache of llvm might be stale for this branch 5db4311 |
Not sure whether that'll fix it, but apologies in retrospect for not versioning these binary filenames when I had to rebuild them for ABI changes. |
No need to apologize since you are the only one who will deal with these. ;-p |
Yay, the compilation passes! |
Yeah, was just a stale cache for whatever reason - had you used this branch name before maybe? So switching from sourceforge to bintray wasn't strictly necessary, but the downloads should be faster and more reliable now. |
I think it's not because of the branch name since it appears on three of my branches Other new branches/PR's also don't have issue using the cache and this issue only appears for whatever commits not having the cpu cores setting, which is why I think it is indexed by the environment settings. |
Ah, the most recent time we ran appveyor without |
Yeah, that makes perfect sense then (I was actually wondering why it has something in the cache if it was a new setting and had never finished the build to get a change to update the cache yet....) I vote for either add checksum or version the filename.... |
We can totally do that. We have the technology. |
Hmmm, did I miss sth or is the cache not updated somehow? https://ci.appveyor.com/project/StefanKarpinski/julia/build/1.0.7095/job/74o9m5aew7cml52m#L32 |
I think the cache only gets updated for branch builds, not pr builds. I could be wrong there. |
Makes sense then. I guess this is also why I don't see the cache update error for other PR builds. So this actually tests that my non-locally-tested code works for both cases? LOL. Should be good to merge then after AppVeyor passes (or if you want to wait for Travis struggling with OSX.....). |
Re-enable running tests with multiple processes on Win64
I'm excited now to see if we are free of the AppVeyor hang in the next few days... |
Changes Unknown when pulling 46147ed on yyc/windows-test into ** on master**. |
Since #7942 should be fixed now.
Somehow I'm getting errors from LLVM headers that seems totally unrelated. The build also takes much longer to download at the beginning.
@tkelman