Add endof for Pair #12335
Merged
Add endof for Pair #12335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Ref #12261 which broke JuMP |
| @@ -441,6 +441,9 @@ getindex(p::Pair,i::Int) = getfield(p,i) | |||
| getindex(p::Pair,i::Real) = getfield(p, convert(Int, i)) | |||
| reverse(p::Pair) = Pair(p.second, p.first) | |||
|
|
|||
| first(p::Pair) = p.first | |||
There was a problem hiding this comment.
Why add this definition if first(::Pair) already works?
|
Alternatively, I think this could be implemented by adding |
|
@joehuchette, could you squash? |
joehuchette
force-pushed
the
jh/last-pair
branch
from
4b6a8a8 to
71ee608
Compare
|
Are there any objections to this? Since you can already do |
|
this lgtm, ci's a bit backed up since there were a lot of merges today |
|
Should help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first(::Pair)already works on master, this adds the correspondinglastmethod.