add warning when incremental compilation will probably fail #12400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| jl_lambda_info_t *li = (jl_lambda_info_t*)jl_expand_in(m->func->linfo->module, (jl_value_t*)ex); | ||
| assert(jl_is_lambda_info(li)); | ||
| li->name = m->func->linfo->name; | ||
| func = jl_new_closure(NULL, (jl_value_t*)jl_emptysvec, li); |
There was a problem hiding this comment.
@JeffBezanson i think this is what you were suggesting for replacing the eval? what does the second argument to jl_new_closure mean in this case (i copied this from interpreter.c)?
Down with monkey-patching! :pitchfork: |
vtjnash
force-pushed
the
jn/static_compile_warn_eval
branch
from
48a45fc to
2149008
Compare
|
The But this is very good, thanks! |
…ntal compilation (close #12352) calling eval into another module during compile-time is almost guaranteed to break incremental compilation the usual symptom would be a segfault during deserialization due to the existance of a type, module, or other data structure in the 'other' module that will not be persisted. it is also possible to 'lose' method definitions because their lambda_info->module field will be assigned incorrectly
vtjnash
force-pushed
the
jn/static_compile_warn_eval
branch
from
2149008 to
8a1d443
Compare
vtjnash
added a commit
that referenced
this pull request
Aug 3, 2015
add warning when incremental compilation will probably fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes incremental compilation noisy when it is pretty sure your code won't work with incremental compilation (due to use of
eval(othermodule, code)so far, I have not seen any false-positives with this, but it was able to find two real errors (with
Images/ColorsandGeometryTypes/FixedSizeArrays)