remove openlibm include for fenv_constants.jl #12471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added this for MSVC in #6230 but it's not actually necessary with MSVC 2013. Maybe it was a 2012-or-earlier thing that got fixed as they added support for more of C99. In a `NO_GIT` build openlibm will be at a different location, so let's not hard-code it.
|
AppVeyor got conflicted between this build and my build system updates #12463, but I've bumped the build number to fix that. |
|
(this change is now included in #12463) |
tkelman
added a commit
that referenced
this pull request
Aug 7, 2015
remove openlibm include for fenv_constants.jl
|
this one's less controversial so may as well do it now, sorry about the rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this for MSVC in #6230 but it's not actually necessary with MSVC 2013.
Maybe it was a 2012-or-earlier thing that got fixed as they added support for more of C99.
In a
NO_GITbuild openlibm will be at a different location, so let's not hard-code it.