-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle CA certs on linux if we have a single cert.pem file #13429
Conversation
# We need to bundle ca certs on linux now that we're using libgit2 with ssl | ||
ifneq ($(shell cat $(shell openssl version -d | cut -d '"' -f 2)/cert.pem),) | ||
-cp $(shell openssl version -d | cut -d '"' -f 2)/cert.pem $(DESTDIR)$(datarootdir)/julia/ | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you decided on a file which is probably covered by GPL.
cc @tkelman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain? thought this was from mozilla ca-certificates? though yes this should be mentioned in LICENSE.md, along with openssl while we're at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. ca-certificates
package on Ubuntu, which generates pem files, is covered by GPL 2. Yes, certificates come from Mozilla but in a plain text (under MPL 2.0), however the script that transforms them into pem
is GPL. So, what kind of licence covers pem
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely MPL 2.0. The FSF has always maintained that compilers etc. do not affect the license of the code being transformed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On CentOS 5 where we build the linux tarball binaries, the cert.pem file comes from the openssl package http://mirror.centos.org/centos/5/os/x86_64/CentOS/openssl-0.9.8e-27.el5_10.4.x86_64.rpm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case dismissed
Bundle CA certs on linux if we have a single cert.pem file
does need mentioning in license.md, but let's see if this fixes nightly travis |
On Ubuntu, make now gives me
I assume that's harmless, but maybe cat's stderr should be redirected to /dev/null? |
I think this may count as a useless use of |
I'm a little skeptical that cert files can even be copyrighted. They seems like data rather than code. |
@tkelman What's a better way of testing for the existence of the file? |
we have a few other places where we shell out to |
This closes #13399