Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle CA certs on linux if we have a single cert.pem file #13429

Merged
merged 1 commit into from
Oct 3, 2015

Conversation

staticfloat
Copy link
Member

This closes #13399

@tkelman tkelman added the system:linux Affects only Linux label Oct 3, 2015
# We need to bundle ca certs on linux now that we're using libgit2 with ssl
ifneq ($(shell cat $(shell openssl version -d | cut -d '"' -f 2)/cert.pem),)
-cp $(shell openssl version -d | cut -d '"' -f 2)/cert.pem $(DESTDIR)$(datarootdir)/julia/
endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you decided on a file which is probably covered by GPL.

cc @tkelman

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain? thought this was from mozilla ca-certificates? though yes this should be mentioned in LICENSE.md, along with openssl while we're at it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. ca-certificates package on Ubuntu, which generates pem files, is covered by GPL 2. Yes, certificates come from Mozilla but in a plain text (under MPL 2.0), however the script that transforms them into pem is GPL. So, what kind of licence covers pem file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely MPL 2.0. The FSF has always maintained that compilers etc. do not affect the license of the code being transformed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On CentOS 5 where we build the linux tarball binaries, the cert.pem file comes from the openssl package http://mirror.centos.org/centos/5/os/x86_64/CentOS/openssl-0.9.8e-27.el5_10.4.x86_64.rpm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case dismissed

staticfloat added a commit that referenced this pull request Oct 3, 2015
Bundle CA certs on linux if we have a single cert.pem file
@staticfloat staticfloat merged commit d16a166 into master Oct 3, 2015
@tkelman tkelman deleted the sf/bundlecerts branch October 3, 2015 05:21
@tkelman
Copy link
Contributor

tkelman commented Oct 3, 2015

does need mentioning in license.md, but let's see if this fixes nightly travis

@josefsachsconning
Copy link
Contributor

On Ubuntu, make now gives me

cat: /usr/lib/ssl/cert.pem: No such file or directory
cat: /usr/lib/ssl/cert.pem: No such file or directory
cat: /usr/lib/ssl/cert.pem: No such file or directory

I assume that's harmless, but maybe cat's stderr should be redirected to /dev/null?

@tkelman
Copy link
Contributor

tkelman commented Oct 3, 2015

I think this may count as a useless use of cat, we should probably just test for the existence of the file rather than shelling out to cat and string-comparing the output to see if it's empty.

@StefanKarpinski
Copy link
Member

I'm a little skeptical that cert files can even be copyrighted. They seems like data rather than code.

@staticfloat
Copy link
Member Author

@tkelman What's a better way of testing for the existence of the file?

@tkelman
Copy link
Contributor

tkelman commented Oct 3, 2015

we have a few other places where we shell out to if [ -e ]; then echo exists; fi that could probably work for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:linux Affects only Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many automated builds/tests are broken with a libgit2 ECERTIFICATE error
6 participants