Allow Val{:_} parameter in chol(::Number, ...), not only a symbol.
#13479
Conversation
| @@ -94,7 +94,8 @@ function chol!(x::Number, uplo) | |||
| rxr = sqrt(rx) | |||
| convert(promote_type(typeof(x), typeof(rxr)), rxr) | |||
| end | |||
| chol(x::Number, uplo::Symbol=:U) = chol!(x, uplo) | |||
There was a problem hiding this comment.
Thanks for fixing this. I think it would be better just to remove the typing, i.e. chol(x::Number, uplo...) = chol!(x). Do you see any problems with that?
There was a problem hiding this comment.
That should be ok, I cannot really think of something which deserves the name number where this would be a problem.
|
This is superseeded by https://github.com/JuliaLang/julia/pull/13680/files. Should it be backported to 0.4? |
|
We don't generally backport syntax changes, renames, deprecations etc. |
|
This is not a syntax change and nothing new, this is just adding a missing method definition which was left out by oversight. |
|
Sorry, thought you were asking if #13680 should be backported. If you want to open against release-0.4 with the version @andreasnoack suggested, and a test, I think that would be okay. |
Define also
chol(::Number::Union{Type{Val{:L}}, Type{Val{:U}}}, aschol(a::AbstractMatrix, uplo::Symbol)is deprecated.