Some promotion and error reporting fixes for eigs #13778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
anj/arpack
branch
from
5ffdf65 to
fa006bc
Compare
andreasnoack
added a commit
that referenced
this pull request
Oct 28, 2015
Some promotion and error reporting fixes for eigs
| @@ -11,7 +11,18 @@ type LAPACKException <: Exception | |||
| end | |||
|
|
|||
| type ARPACKException <: Exception | |||
| info::BlasInt | |||
| info::ByteString | |||
There was a problem hiding this comment.
this is technically breaking and iffy to backport
There was a problem hiding this comment.
Yes. That's true. We could backport the promotion commit only, or assume that nobody relies on the internals of ARPACKException which is probably a safe assumption. They are thrown very rarely because we capture most of the errors with checks before calling ARPACK.
|
I don't think anyone relies on the internals of ARPACKException. Let's backport it - since it is a significantly better experience. |
| eigs(A::AbstractMatrix{BigFloat}, B::AbstractMatrix...; kwargs...) = throw(MethodError(eigs, Any[A,B,kwargs...])) | ||
| eigs(A::AbstractMatrix{BigFloat}, B::UniformScaling; kwargs...) = throw(MethodError(eigs, Any[A,B,kwargs...])) | ||
| function eigs{T}(A::AbstractMatrix{T}, ::UniformScaling; kwargs...) | ||
| Tnew = typeof(zero(T)/sqrt(one(T))) |
There was a problem hiding this comment.
we should just define float(T), or AbstractFloat(T) as suggested in #13445. I hate this kind of typeof construction.
float(T::Type) = typeof(float(zero(T))) would be a decent fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/LinearAlgebra.jl#269 and JuliaLang/LinearAlgebra.jl#274