Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for pair printing & sparsevec #13943

Merged
merged 2 commits into from
Nov 11, 2015
Merged

Tests for pair printing & sparsevec #13943

merged 2 commits into from
Nov 11, 2015

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Nov 11, 2015

Sparsevec’s scale and {c}transpose methods needed tests, as did printing of Pairs.

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Nov 11, 2015
@@ -303,6 +303,11 @@ function f13127()
end
@test f13127() == "f"

a = Pair(1.0,2.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a let, and sprint(show, a)

@kshyatt
Copy link
Contributor Author

kshyatt commented Nov 11, 2015

Looks like an unrelated parallel failure. This ok now?

@tkelman
Copy link
Contributor

tkelman commented Nov 11, 2015

restarted just to be on the safe side

kshyatt added a commit that referenced this pull request Nov 11, 2015
Tests for pair printing & sparsevec
@kshyatt kshyatt merged commit 34ee45c into master Nov 11, 2015
@kshyatt kshyatt deleted the ksh/testgrab branch November 11, 2015 18:21
@tkelman
Copy link
Contributor

tkelman commented Nov 11, 2015

first commit here should be backport-worthy, not the second though since 0.4 doesn't have SparseVector

kshyatt added a commit that referenced this pull request Nov 29, 2015
(cherry picked from commit c829f84)
ref #13943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants