Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around issue #12166, .julia on a network drive on Windows #14026

Merged
merged 3 commits into from
Nov 18, 2015
Merged

Work around issue #12166, .julia on a network drive on Windows #14026

merged 3 commits into from
Nov 18, 2015

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Nov 17, 2015

ref #12166

@tkelman tkelman added system:windows Affects only Windows packages Package management and loading backport pending 0.4 labels Nov 17, 2015
@tkelman
assume Pkg.clone input is a url if it contains :
bae49b9 
Assuming we're highly unlikely to allow colons in registered package names

Works around `ERROR: stat: unknown error (UNKNOWN)` when calling stat
on a network-drive path with multiple colons in it
@tkelman
Copy link
Contributor Author

tkelman commented Nov 17, 2015

cc @twadleigh if you may want to test this (though the msys2 build is probably still broken, see https://s3.amazonaws.com/julianightlies/bin/winnt/x64/0.5/julia-0.5.0-bae49b97a8-win64.exe if binaries would be easier)

tkelman added a commit that referenced this pull request Nov 18, 2015
@tkelman
Merge pull request #14026 from JuliaLang/tk/12166test
ea2ab73 
Work around issue #12166, .julia on a network drive on Windows
@tkelman tkelman merged commit ea2ab73 into master Nov 18, 2015
@tkelman tkelman deleted the tk/12166test branch November 18, 2015 12:09
@tkelman tkelman mentioned this pull request Nov 18, 2015
Closed
tkelman added a commit that referenced this pull request Nov 18, 2015
@tkelman
put a try around the symlink in mkcachedir
d332bd4 
ref issue 12166

(cherry picked from commit 6b979b6)
from PR #14026
@tkelman
Copy link
Contributor Author

tkelman commented Nov 19, 2015

the ERROR: stat: unknown error (UNKNOWN) should be fixed upstream by libuv/libuv#623, and in our fork by JuliaLang/libuv@3aaf11c

@tkelman tkelman mentioned this pull request Nov 26, 2015
Closed
tkelman added a commit that referenced this pull request Dec 2, 2015
@tkelman
Don't use shared pkg .cache directory any more on Windows
61d1087 
The directory junctions created by `symlink` are proving too problematic with respect to network drives.
This essentially reverts #7361. Ref #14026 and #14205.
@tkelman tkelman mentioned this pull request Dec 2, 2015
Merged
tkelman added a commit that referenced this pull request Dec 2, 2015
@tkelman
Don't use shared pkg .cache directory any more on Windows
084c906 
The directory junctions created by `symlink` are proving too problematic with respect to network drives.
This essentially reverts #7361. Ref #14026 and #14205.
(cherry picked from commit 61d1087)
ref #14225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages Package management and loading system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tkelman