Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the stateful jl_parse_next API #14707

Merged
merged 1 commit into from
Jan 19, 2016
Merged

remove the stateful jl_parse_next API #14707

merged 1 commit into from
Jan 19, 2016

Conversation

JeffBezanson
Copy link
Member

With this change, we parse a whole file at once to a toplevel expression with interleaved line nodes. This is much simpler.

cc @yuyichao

@yuyichao
Copy link
Contributor

👍

@JeffBezanson
Copy link
Member Author

Looks like #14705

@tkelman
Copy link
Contributor

tkelman commented Jan 18, 2016

just double checking, the mechanism for __precompile__ doesn't depend on this incremental parsing, does it?

@JeffBezanson
Copy link
Member Author

I don't believe so; this should only affect the stage before macro expansion, so no julia code is running.

@maleadt
Copy link
Member

maleadt commented Jan 18, 2016

Can the jl_parse_next forward declaration in src/julia_internal.h be removed too? There also seem to be some references to the API in devdocs/init.rst and src/ast.c.

@JeffBezanson
Copy link
Member Author

Ah yes, thanks for finding those.

JeffBezanson added a commit that referenced this pull request Jan 19, 2016
remove the stateful `jl_parse_next` API
@JeffBezanson JeffBezanson merged commit 629da71 into master Jan 19, 2016
@tkelman tkelman deleted the jb/simplerparse branch January 19, 2016 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants