Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLVM 3.9 API breakage #14744

Merged
merged 1 commit into from
Jan 22, 2016
Merged

Fix LLVM 3.9 API breakage #14744

merged 1 commit into from
Jan 22, 2016

Conversation

yuyichao
Copy link
Contributor

Didn't check which commit is this but ObjSetT is std::vector<std::unique_ptr<llvm::object::OwningBinary<llvm::object::ObjectFile>>> on LLVM 3.9 now.

c.c. @Keno

@Keno
Copy link
Member

Keno commented Jan 20, 2016

That's somewhat odd. OwningBinary already does lifetime management. I should check with whoever changed that.

@yuyichao
Copy link
Contributor Author

llvm-mirror/llvm@1665b57

@Keno
Copy link
Member

Keno commented Jan 20, 2016

Thanks.

@yuyichao
Copy link
Contributor Author

@Keno Any update? Is the change intentional or will it be reverted?

@Keno
Copy link
Member

Keno commented Jan 22, 2016

Sounds like it'll stay so lgtm.
On Jan 22, 2016 13:51, "Yichao Yu" notifications@github.com wrote:

@Keno https://github.com/Keno Any update? Is the change intentional or
will it be reverted?


Reply to this email directly or view it on GitHub
#14744 (comment).

yuyichao added a commit that referenced this pull request Jan 22, 2016
@yuyichao yuyichao merged commit df928bd into master Jan 22, 2016
@yuyichao yuyichao deleted the yyc/llvm39-binary branch January 22, 2016 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants