-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JSON parsing performance #1538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While you're at it, can you capitalize JSON as per #1537 (I would but I don't want to wreak conflict havoc). |
Sure, will do. |
Needs rebase. |
…orted method name, since it is namespaced via the module.
…l comprehensions due to JuliaLang#1457
Done. |
JeffBezanson
added a commit
that referenced
this pull request
Nov 16, 2012
Improve JSON parsing performance
fredrikekre
pushed a commit
that referenced
this pull request
Dec 13, 2019
…34091) git log --oneline 0c2dddd40e4d7492d2a7337be54c345011e5f1e1^..8e236a7f993f1e732ffd0ab5c15736b2594e4109 8e236a7 (HEAD -> master, origin/master, origin/HEAD) Merge pull request #1544 from JuliaLang/sk/telemetry 90b8482 telemetry: factor out telemetry file loading 228fb97 CI telemetry: send indicators for common CI env vars 246dbd0 Pkg protocol: basic anonymous opt-out telemetry e66a75f Introduce special REPL syntax for shared environments (#1488) afeb1ee Merge pull request #1538 from JuliaLang/sk/pkg-client-auth 9c357bb Pkg client auth: support connecting to authenticated Pkg servers 6dd7f34 PlatformEngines: revert API part of headers support (broken) 6825b48 Merge pull request #1539 from 00vareladavid/00/fixes 3f1cf40 it is invalid to `add` a package with no commits 0766765 test: default environment should be created when the primary depot does not exist 43f46f8 check no overwrite is occuring when resolving from a project file 37b6853 handle primary depot as relative path 53fdf24 Check for duplicate name/UUID input 8a6387c Remove redundant precompile statement 4d0901e Dont throw error when autocompleting faulty input (#1530) d69f6d7 Refactor and test `Pkg.test` (#1427) 8ca8b6d PlatformEngines: use `tar -m` to ignore mtimes (#1537) 6797928 Make sure sandbox's temp Project.toml and Manifest.toml files are writable (#1534) f968cc9 clarify: stacked envs only affect top-level loading (#1529) 0dfef59 PlatformEngines.download: add header support (#1531) 49ab53e Fix tree hashing with nested empty directories (#1522) 0c2dddd fix #1514: install_archive call in backwards_compatible_isolation (#1517)
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
…34091) git log --oneline 0c2dddd40e4d7492d2a7337be54c345011e5f1e1^..8e236a7f993f1e732ffd0ab5c15736b2594e4109 8e236a7 (HEAD -> master, origin/master, origin/HEAD) Merge pull request #1544 from JuliaLang/sk/telemetry 90b8482 telemetry: factor out telemetry file loading 228fb97 CI telemetry: send indicators for common CI env vars 246dbd0 Pkg protocol: basic anonymous opt-out telemetry e66a75f Introduce special REPL syntax for shared environments (#1488) afeb1ee Merge pull request #1538 from JuliaLang/sk/pkg-client-auth 9c357bb Pkg client auth: support connecting to authenticated Pkg servers 6dd7f34 PlatformEngines: revert API part of headers support (broken) 6825b48 Merge pull request #1539 from 00vareladavid/00/fixes 3f1cf40 it is invalid to `add` a package with no commits 0766765 test: default environment should be created when the primary depot does not exist 43f46f8 check no overwrite is occuring when resolving from a project file 37b6853 handle primary depot as relative path 53fdf24 Check for duplicate name/UUID input 8a6387c Remove redundant precompile statement 4d0901e Dont throw error when autocompleting faulty input (#1530) d69f6d7 Refactor and test `Pkg.test` (#1427) 8ca8b6d PlatformEngines: use `tar -m` to ignore mtimes (#1537) 6797928 Make sure sandbox's temp Project.toml and Manifest.toml files are writable (#1534) f968cc9 clarify: stacked envs only affect top-level loading (#1529) 0dfef59 PlatformEngines.download: add header support (#1531) 49ab53e Fix tree hashing with nested empty directories (#1522) 0c2dddd fix #1514: install_archive call in backwards_compatible_isolation (#1517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve JSON parsing performance by about 30% (and more when values are long strings) by using a regex to pre-calculate string delimiters and escape characters.