Flip the concatenation switch #15921
Conversation
| # TODO: this is currently much faster. should figure out why. not clear. | ||
| copy!(Array(T,length(X)), X) | ||
| end | ||
| const _oldstyle_array_vcat_ = false # TODO: deprecate/remove in 0.6 |
There was a problem hiding this comment.
move it to deprecated.jl if it's really just an appendix for the sake of letting people check it?
There was a problem hiding this comment.
Maybe I was being overzealous, but I was thinking that we might need to wait until the next release cycle: the whole point of adding this must have been to allow people to check, and it seems unfair to immediately issue a deprecation warning the moment anyone actually gets benefit from having used it. It doesn't seem to hurt anything to wait until another release cycle before deprecating this binding.
There was a problem hiding this comment.
I just mean moving the definition to deprecated.jl so we remember to delete it eventually
There was a problem hiding this comment.
I see. My biggest concern is whether someone will just nuke the old deprecations when starting on the next cycle. But I could move it and have a HUGE comment explaining my intentions.
Completes #8599. Part of JuliaLang/LinearAlgebra.jl#255.