Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Enable threading build by default, but with only 1 thread #15997

Merged
merged 1 commit into from
Apr 24, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Apr 22, 2016

unless you opt in to setting JULIA_NUM_THREADS
closes #15743

Anything else I missed here? Let's see what kind of regressions this might bring:
runbenchmarks(ALL, vs = "JuliaLang/julia:master")

unless you opt in to setting JULIA_NUM_THREADS
closes #15743
@tkelman tkelman added the multithreading Base.Threads and related functionality label Apr 22, 2016
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@jrevels
Copy link
Member

jrevels commented Apr 22, 2016

As you're probably aware by now, the regressions here (and likely the improvements as well) come from very noisy benchmarks, especially sort. It shouldn't be long until my fixes for all this stuff get officially deployed to @nanosoldier...

@StefanKarpinski
Copy link
Member

Are we using a fixed seed for the sort benchmark?

@jrevels
Copy link
Member

jrevels commented Apr 22, 2016

Yes. The issue is that the old version of that benchmark (the one currently on @nanosoldier) naively incorporates the allocation of the input vector into the sample measurements. This is fixed in the new version of the suite, but I'm still running tests on the new version and haven't deployed it yet.

@tkelman
Copy link
Contributor Author

tkelman commented Apr 23, 2016

Sounds like we should go ahead and do this then?

@tkelman tkelman changed the title WIP: Enable threading build by default, but with only 1 thread RFC: Enable threading build by default, but with only 1 thread Apr 23, 2016
@tkelman tkelman merged commit 733e744 into master Apr 24, 2016
@tkelman tkelman deleted the tk/defaultthreads branch April 24, 2016 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multithreading Base.Threads and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Towards enabling multi-threading on master
4 participants