inference of splatting constant containers #16006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Tuple{a.parameters..., b.parameters...} | ||
| end | ||
| @test Base.return_types(cat10880, Tuple{Type{Tuple{Int8,Int16}},Type{Tuple{Int32}}})[1] == | ||
| Type{Tuple{Int8,Int16,Int32}} |
There was a problem hiding this comment.
@inferred cat10880(Tuple{Int8,Int16}, Tuple{Int32}) ?
|
Interesting; seems to be timing out on both 32-bit builds. |
JeffBezanson
force-pushed
the
jb/fix10880
branch
from
fb90a7b to
d6b80d2
Compare
| @@ -2333,7 +2333,7 @@ function inlineable(f::ANY, ft::ANY, e::Expr, atypes::Vector{Any}, sv::Inference | |||
| if (is(f,apply_type) || is(f,fieldtype) || is(f,typeof) || | |||
| istopfunction(topmod, f, :typejoin) || | |||
| istopfunction(topmod, f, :promote_type)) | |||
| if effect_free(argexprs[2], sv, true) | |||
| if length(argexprs) < 2 || effect_free(argexprs[2], sv, true) | |||
There was a problem hiding this comment.
probably the cause of
From worker 6: * arrayops Test Failed
From worker 6: Expression: isleaftype((Base.return_types(f,()))[1])
From worker 2: * linalg/triangular in 1022.93 seconds, maxrss 893.98 MB
in 1098.36 seconds, maxrss 880.96 MB
* linalg/qr rec_backtrace at /home/Tony/julia/src/home/Tony/julia/src\stackwalk.c:83
record_backtrace at /home/Tony/julia/src/home/Tony/julia/src\task.c:228
jl_throw at /home/Tony/julia/src/home/Tony/julia/src\task.c:522
jl_bounds_error_ints at /home/Tony/julia/src/home/Tony/julia/src\builtins.c:169
getindex at .\array.jl:309
unknown function (ip: 0000000000D0211F)
jl_call_method_internal at /home/Tony/julia/src/home/Tony/julia/src\julia_internal.h:85
inlineable at .\inference.jl:2334
jl_call_method_internal at /home/Tony/julia/src/home/Tony/julia/src\julia_internal.h:85
inlining_pass at .\inference.jl:2955
?
There was a problem hiding this comment.
Yes, that commit should be copied to another branch for faster merging.
There was a problem hiding this comment.
how bout master. it did just run on CI and only hit #16556
There was a problem hiding this comment.
Cherry pick away.
BTW, where did you see this failure?
There was a problem hiding this comment.
74b3042, locally, win64. Heavily loaded at the time, not sure if that's related.
tkelman
pushed a commit
that referenced
this pull request
Jun 15, 2016
cherry-picked from #16006, see discussion there
|
bump. seems like this should be uncontroversial? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bunch of errors during bootstrap, such as
<: not definedwhile trying to pure_eval_calltypejoin, and some other similar issues. I also hit a problem due to the linearindexing trait of BitArray being defined way, way later than the type itself.