More general indexing [4] #16203
Merged
More general indexing [4] #16203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -222,17 +222,17 @@ format(dt::TimeType,f::AbstractString;locale::AbstractString="english") = format | |||
| # vectorized | |||
| DateTime{T<:AbstractString}(y::AbstractArray{T},format::AbstractString;locale::AbstractString="english") = DateTime(y,DateFormat(format,locale)) | |||
| function DateTime{T<:AbstractString}(y::AbstractArray{T},df::DateFormat=ISODateTimeFormat) | |||
| return reshape(DateTime[DateTime(parse(y[i],df)...) for i in 1:length(y)], size(y)) | |||
There was a problem hiding this comment.
These could be even nicer (no bounds-checking) with
function foo(Y::AbstractArray)
[y for y in Y]
end
dfdx
force-pushed
the
more-general-indexing-4
branch
from
8386d11 to
ba52671
Compare
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another portion of improvements for more efficient iteration over different types of arrays. This PR covers lines from
to
from this list except for
cartesian.jl, which may need more careful treatment (especially in macros).