Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also skip linalg/triangular on osx travis #16210

Merged
merged 3 commits into from
May 6, 2016
Merged

Also skip linalg/triangular on osx travis #16210

merged 3 commits into from
May 6, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented May 5, 2016

should give a bit more leeway on timeouts

and add a test that was causing segfaults on windows with llvm 3.8 in #15417 but is no longer hit by the subarray tests since #15431 was merged, and remove a duplicate convert method that's causing a warning during bootstrap

@tkelman tkelman added the test This change adds or pertains to unit tests label May 5, 2016
this particular set of inputs is not tested any more since the
APL indexing PR was merged

Apparently the shape returned by collect of a subarray changed too
@kshyatt
Copy link
Contributor

kshyatt commented May 5, 2016

How can we make the triangular tests faster? Would breaking that file up into multiple pieces help?

@tkelman
Copy link
Contributor Author

tkelman commented May 5, 2016

Possibly. That file is largely a set of nested loops over a bunch of types, so it would only help if the top-level loops are comparable in runtime. If one is much slower than the other it won't make as much difference.

@andreasnoack
Copy link
Member

I think it would make it worse since it is more likely that the same
methods for XTriangular will be compiled at different processes.

On Thu, May 5, 2016 at 1:44 PM, Tony Kelman notifications@github.com
wrote:

Possibly. That file is largely a set of nested loops over a bunch of
types, so it would only help if the top-level loops are comparable in
runtime. If one is much slower than the other it won't make as much
difference.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#16210 (comment)

@tkelman tkelman merged commit fcb41d5 into master May 6, 2016
@tkelman tkelman deleted the tk/osxtravis branch May 6, 2016 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra performance Must go faster test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants