Fix \ bug introduced in PR#15354 by removing parent of sub. #16473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @timholy pointed out in #15354 I, quite embarrassingly, introduced a bug in A\v for A being a
Factorization
, and v being aSubArray
with complex elements, by inappropriately usingparent
. I have proposed a one-line fix, which does not at all useSubArray
s in a good way, but it will give the correct result. I guess this is related to the whole discussion on inefficient fallback methods. I am happy to take advice and criticism if there's a better way.edit: didn't run all tests locally, so didn't catch the problems visible at CIs. I'll try to fix it.
edit^2: fixed by defining it in the most general ("Factorization","SubArray") case.