Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: try to simplify information flow around inference #16929

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Conversation

JeffBezanson
Copy link
Member

Attempting some cleanup here. cc @vtjnash

  • Remove code for copying data from one LambdaInfo to another; instead have only one LambdaInfo.
  • typeinf_edge was calling jl_specializations_insert on a LambdaInfo even if it already came from the cache.
  • Combine creating and caching specializations into one step.
  • Be more careful about where linfo->inInference is set to 1.
  • In general try to avoid potential re-entrance problems in typeinf.

@vtjnash
Copy link
Member

vtjnash commented Jun 14, 2016

nice! I didn't realize this was so close to be being fully functional.

lgtm.

@StefanKarpinski
Copy link
Member

a5c1fa46-f3e6-4b04-a5a7-19777218e4c6

@JeffBezanson
Copy link
Member Author

Unfortunately had to give up some of the code reduction in order to handle deleted IR. Oh well.

@vtjnash vtjnash merged commit 4accf8a into master Jun 16, 2016
@vtjnash vtjnash deleted the jb/linfocopying branch June 16, 2016 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants