Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Implement operators on Nullable with lifting semantics #16988

Closed
wants to merge 2 commits into from
Closed

RFC: Implement operators on Nullable with lifting semantics #16988

wants to merge 2 commits into from

Commits on Jun 17, 2016

  1. Fix StackOverflow error with >>, << and >>> on Bool and Unsigned 

    Error was triggered e.g. by false >> 0x01.
    @nalimilan
    nalimilan committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    f143ae0 View commit details
    Browse the repository at this point in the history

  2. Implement operators for Nullable with lifting semantics 

    Use fast path without a branch for types with unchecked arithmetic
(for which the operation can be computed even when value is missing)
and a slow path for other types. The new null_safe_op() function
allows custom types to opt-in to the fast path when possible.
Also use this strategy in isequal(), which keeps its current
(non-lifting) behavior.
    @nalimilan
    nalimilan committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    ef687a3 View commit details
    Browse the repository at this point in the history