Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant SubArray tests #17336

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Remove redundant SubArray tests #17336

merged 1 commit into from
Jul 12, 2016

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 8, 2016

Now that we have only view rather than both sub and slice, we can cut the number of executed tests in subarray.jl nearly in half. Sadly, this has negligible effect on the test time, because the time is nearly 100% codegen (the infamous loop goes from >200s to under 1s if you run it a second time, as long as you don't redefine runsubarraytests and runviews).

Still, it seems worth deleting duplicated code.

@tkelman
Copy link
Contributor

tkelman commented Jul 9, 2016

appveyor failure looks like #16091 (comment)

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Jul 11, 2016
@tkelman tkelman merged commit 38c803d into master Jul 12, 2016
@tkelman tkelman deleted the teh/subarray_redundancies branch July 12, 2016 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants