Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have only
view
rather than bothsub
andslice
, we can cut the number of executed tests insubarray.jl
nearly in half. Sadly, this has negligible effect on the test time, because the time is nearly 100% codegen (the infamous loop goes from >200s to under 1s if you run it a second time, as long as you don't redefinerunsubarraytests
andrunviews
).Still, it seems worth deleting duplicated code.