Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make setindex! for sparse matrices and vectors not purge stored entries on zero assignment #17404

Merged
merged 10 commits into from
Jul 19, 2016
Merged

Make setindex! for sparse matrices and vectors not purge stored entries on zero assignment #17404

merged 10 commits into from
Jul 19, 2016

Commits on Jul 14, 2016

  1. Rewrite setindex!(A::SparseMatrixCSC, v, i, j) such that it no longer… 

    … expunges stored entries on zero assignment, throws a more explicit BoundsError when needed, and also for simplicity and clarity. Also add tests.
    @Sacha0
    Sacha0 committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    7241554 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2016

  1. Rework setindex!(A::SparseMatrixCSC, v, I, J) such that it no longer … 

    …expunges stored entries on zero assignment. Also add tests.
    @Sacha0
    Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    49712aa View commit details
    Browse the repository at this point in the history

  2. Revise setindex!(A::SparseMatrixCSC, B::SparseMatrixCSC, I, J) such t… 

    …hat, when an assigning zero to entry A[i,j], if A[i,j] is not presently stored, the method does not introduce storage for A[i,j]. Also add tests.
    @Sacha0
    Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    a464345 View commit details
    Browse the repository at this point in the history

  3. Revise setindex!(A::SparseMatrixCSC, x, I::AbstractMatrix{Bool}) such… 

    … that it no longer expunges stored entries on zero assignment. Also add tests.
    @KristofferC @Sacha0
    KristofferC authored and Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    606a8e4 View commit details
    Browse the repository at this point in the history

  4. Revise setindex!(A::SparseMatrixCSC, x, I::AbstractVector) such that … 

    …it no longer expunges stored entries on zero assignment. Also add tests.
    @KristofferC @Sacha0
    KristofferC authored and Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    6d3e198 View commit details
    Browse the repository at this point in the history

  5. Introduce rudimentary dropstored! methods for dropping stored entries… 

    … from SparseMatrixCSCs.
    @Sacha0
    Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    de37969 View commit details
    Browse the repository at this point in the history

  6. Introduce tests for dropstored!(A, i, j) and dropstored!(A, I, J).

    @Sacha0
    Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    ffc5be2 View commit details
    Browse the repository at this point in the history

  7. Revise setindex!(x::SparseVector, v, i) such that it no longer purges… 

    … stored entries on zero assignment. Modify tests accordingly.
    @Sacha0
    Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    f98987f View commit details
    Browse the repository at this point in the history

  8. Introduce rudimentary dropstored! method for dropping entries from Sp… 

    …arseVectors. Also introduce associated tests.
    @Sacha0
    Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    16971a4 View commit details
    Browse the repository at this point in the history

  9. Note in NEWS.md that setindex! for sparse matrices and vectors no lon… 

    …ger purges allocated entries on zero assignment and that dropstored! now exists to drop stored entries.
    @Sacha0
    Sacha0 committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    59d3d7c View commit details
    Browse the repository at this point in the history