Fix incorrect bignum rng buffer size in libssh2-mbedtls backend #17874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Modifying the existing patch file means people will need to do a distclean to have it actually take effect, but I guess that's not the end of the world since you'll know if you're having the issue and these libraries aren't that big. |
wildart
force-pushed
the
art/fix-17772
branch
2 times, most recently
from
8e73035
to
7550fc6
Compare
|
Is this up-to-date / ready, or is fixing libssh2/libssh2#106 (comment) still needed? |
|
This looks up be up to date with that PR, meaning at least the comment you linked to should be addressed. |
|
Let's merge this, and if it needs more adjustment as review goes on with upstream then we can continue fixing it. |
tkelman
pushed a commit
that referenced
this pull request
Aug 11, 2016
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #17772, and also removes need in patching mbedtls itself. Proper PR is corrected in
libssh2as well.