Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure :push_loc meta always has a corresponding :pop_loc #18180

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

yuyichao
Copy link
Contributor

  • Preserve meta node and line number info during dead code elimination
  • Insert :push_loc and :pop_loc in pairs during lowering

Fix #16578

@yuyichao yuyichao added compiler:lowering Syntax lowering (compiler front end, 2nd stage) compiler:inference Type inference labels Aug 22, 2016
@yuyichao
Copy link
Contributor Author

This adds a SSAValue in some cases so

@nanosoldier runbenchmarks(ALL, vs = ":master")

Also, why is circleci trying to build on this pr without a config file?

@tkelman
Copy link
Contributor

tkelman commented Aug 22, 2016

Also, why is circleci trying to build on this pr without a config file?

Because it's kinda dumb. Ignore it while we try to get #18007 up and running.

@nanosoldier
Copy link
Collaborator

Something went wrong when running your job: RemoteException(2,CapturedException(NanosoldierError: failed to run benchmarks against primary commit: ErrorException("failed process: Process(make, ProcessExited(2)) [2]"),Any[( in pipeline_error at process.jl:612,1),( in run at process.jl:588,1),( in build_julia! at build.jl:54,1),( in execute_benchmarks! at BenchmarkJob.jl:251,1),( in run at BenchmarkJob.jl:178,1),( in #503 at multi.jl:1410,1),( in run_work_thunk at multi.jl:996,1),( in macro expansion at multi.jl:1410 [inlined],1),( in #502 at event.jl:46,1)]))
cc @jrevels

@tkelman
Copy link
Contributor

tkelman commented Aug 22, 2016

We should probably revert #18164 until we're sure it works from a clean build. I guess a side effect of running nanosoldier more often is that it tests that configuration, and on a fast enough machine that it doesn't take forever to do so.

@yuyichao
Copy link
Contributor Author

@nanosoldier runbenchmarks(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

* Preserve meta node and line number info during dead code elimination
* Insert `:push_loc` and `:pop_loc` in pairs during lowering

Fix #16578
@yuyichao
Copy link
Contributor Author

Comment? I can't really reproduce the two regressions in the nanosoldier report so I'm tempting to believe it's just noise.

@yuyichao yuyichao merged commit e6a9d7f into master Aug 26, 2016
@yuyichao yuyichao deleted the yyc/codegen/meta branch August 26, 2016 09:58
tkelman pushed a commit that referenced this pull request Aug 29, 2016
* Preserve meta node and line number info during dead code elimination
* Insert `:push_loc` and `:pop_loc` in pairs during lowering

Fix #16578

(cherry picked from commit b929c56)
ref #18180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants