-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure :push_loc
meta always has a corresponding :pop_loc
#18180
Conversation
This adds a @nanosoldier Also, why is circleci trying to build on this pr without a config file? |
Because it's kinda dumb. Ignore it while we try to get #18007 up and running. |
Something went wrong when running your job: |
We should probably revert #18164 until we're sure it works from a clean build. I guess a side effect of running nanosoldier more often is that it tests that configuration, and on a fast enough machine that it doesn't take forever to do so. |
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
* Preserve meta node and line number info during dead code elimination * Insert `:push_loc` and `:pop_loc` in pairs during lowering Fix #16578
662a51c
to
b929c56
Compare
Comment? I can't really reproduce the two regressions in the nanosoldier report so I'm tempting to believe it's just noise. |
:push_loc
and:pop_loc
in pairs during loweringFix #16578