Revert the part of #18164 that broke the build #18194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, just missing the |
|
you couldn't have said that earlier? 78371b3#commitcomment-18719351 |
|
Since you merged that, I did not get a notification. Sorry, would have said something had I seen it. |
|
every nanosoldier build anyone has triggered across 3 or 4 different PR's against master has failed for the same reason |
of cmake projects with gcc - CC_ARG and CXX_ARG are getting double processed somewhere, so cmake is trying to call the compiler as '/usr/bin/gcc gcc' add cut -s
tkelman
force-pushed
the
tk/revert-broken-part-of-18164
branch
from
cdbb726 to
30478fc
Compare
|
Well, then someone should have pinged me because I didn't see it. Not sure what else you expect me to say. |
|
Aren't you watching the repo? CI doesn't build deps from scratch, it caches them. When people make build changes, please test them locally in a from scratch build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of cmake projects with gcc - CC_ARG and CXX_ARG are getting double processed
somewhere, so cmake is trying to call the compiler as '/usr/bin/gcc gcc'