hopefully unbreak osx travis llvm linking #18241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, didn't think about this. My bad. Looks like you've got the right fix cooked up though. |
|
Got to starting the tests, which is successful for the purposes of this change. |
tkelman
added a commit
that referenced
this pull request
Aug 29, 2016
ref staticfloat/homebrew-julia@f57dcc2#diff-633fd9f8448015391714f35e04d39b5bL154 [av skip] (cherry picked from commit ad73afa)
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref staticfloat/homebrew-julia@f57dcc2#diff-633fd9f8448015391714f35e04d39b5bL154
This is unrelated to the fact that a bunch of builds took forever to start (and I cancelled many of them, will restart after we merge this) which was an infrastructure problem on Travis' side - https://www.traviscistatus.com/incidents/4mvp857qx8bw
cc @staticfloat take care with updating the homebrew-julia deps in ways that travis will see here