Clean up redirect_* APIs after Pipe -> PipeEndpoint rename #18253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These probably should have been cleaned up along side that in #12739. Certainly the documentation was out of date, since it referred to `Pipe`, but meant what is now called `PipeEndpoint`. Clean all of this up, by allowing an unitinalized `Pipe` to be passed to these functions, and also by replacing the tuple of `PipeEndpoint`s, by `Pipe`, since the purpose of `Pipe` is precisely to hold two endpoints.
|
run |
|
I suspect this'll need a deprecation (defining iteration over Pipe to return |
| @@ -946,11 +946,13 @@ for (x, writable, unix_fd, c_symbol) in | |||
| handle.handle) | |||
| handle | |||
| end | |||
| function ($f)(handle::Pipe) | |||
| link_pipe(handle, julia_only_read = $(writable), julia_only_write = $(!writable)) | |||
There was a problem hiding this comment.
probably needs to check whether the Pipe is already open, following logic from
Lines 410 to 412 in f06840e
There was a problem hiding this comment.
the $f function on line 944 is also missing an isopen test
|
Replaced by #39132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These probably should have been cleaned up along side that in #12739.
Certainly the documentation was out of date, since it referred to
Pipe,but meant what is now called
PipeEndpoint. Clean all of this up, byallowing an unitinalized
Pipeto be passed to these functions, andalso by replacing the tuple of
PipeEndpoints, byPipe, since thepurpose of
Pipeis precisely to hold two endpoints.