Added PkgError throw to Pkg.status() in entry.jl with simple test. #18293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,6 +125,7 @@ function installed(pkg::AbstractString) | |||
| end | |||
|
|
|||
| function status(io::IO; pkgname::AbstractString = "") | |||
| if ispath(pkgname) || throw(PkgError("package $pkgname does not exist")) end | |||
There was a problem hiding this comment.
The best way to conditionally throw exceptions like this is a little simpler; just omit if and end. For example,
ispath(pkgname) || throw(PkgError("Package $pkgname does not exist"))Alternatively (preferred if the condition or error message is too long for one line), you can do
if !ispath(pkgname)
throw(PkgError("Package $pkgname does not exist"))
end
|
Hey @ras9841, thanks for contributing! Overall this is a nice first PR. However, it looks like the addition of the error caused a test failure. In particular, check out this portion of the Travis log. The test that's failing is this one: @test sprint(io -> Pkg.status(io)) == "No packages installed\n"I think that behavior is still desired, so you'll have to find a way to preserve that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my solution to issue #18206. This is my first contribution, so I welcome any feedback.