Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed confusing array of types in readcsv help #18308

Merged
merged 3 commits into from
Sep 6, 2016

Conversation

mbeltagy
Copy link
Contributor

No description provided.

@tkelman
Copy link
Contributor

tkelman commented Aug 31, 2016

this isn't an array, it's actually trying to say that the type input is optional (another reason why I think we should just use Julia syntax for that optional argument convention in docstrings)

@ViralBShah
Copy link
Member

Cc @tanmaykm

@kshyatt kshyatt added docs This change adds or pertains to documentation io Involving the I/O subsystem: libuv, read, write, etc. labels Aug 31, 2016
@mbeltagy
Copy link
Contributor Author

I believe we need better standards for documenting optional arguments. In the manual I sometimes see it as

foo(arg [,optional_arg])

So maybe we need to have that for all optional arguments in the docs, instead of the often ambiguous

foo(arg, [optional_arg])

@tanmaykm
Copy link
Member

tanmaykm commented Sep 1, 2016

I think we can merge this.
And also open an issue to have a uniform standard for documenting optional arguments.

@tkelman
Copy link
Contributor

tkelman commented Sep 1, 2016

it would need a genstdlib run. and it's probably covered by #18041, but worth checking

@mbeltagy
Copy link
Contributor Author

mbeltagy commented Sep 1, 2016

I checked #18041 and found that the [optional_arg] style was used. This is often at odds with the manual. So I created #18318.

@kshyatt
Copy link
Contributor

kshyatt commented Sep 5, 2016

@mbeltagy in that PR I was just trying to get as much stuff out of HelpDB as possible, not really overhaul all those docs (although some of that ended up happening). I agree that the square brackets aren't great. Have you run genstdlib? Is this good to go?

@mbeltagy
Copy link
Contributor Author

mbeltagy commented Sep 6, 2016

@kshyatt I ran genstdlib. It is good to go.
I could start an effort to remove square brackets from the docs, if you think it is worth while. I get a feeling that the community has not been happy with them for some time. (c.f. #4902)

@tkelman
Copy link
Contributor

tkelman commented Sep 6, 2016

A correct run of genstdlib needs to happen after bootstrapping and should change the rst docs. You'd need to commit and push that change.

@tkelman tkelman merged commit 22cc7a5 into JuliaLang:master Sep 6, 2016
tkelman pushed a commit that referenced this pull request Sep 6, 2016
* Removed confusing array of types in readcsv

* Restored brackets to `T` in readcsv doc and added clarifying text

* genstdlib rst output for docstring change.

(cherry picked from commit 22cc7a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants