-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed confusing array of types in readcsv help #18308
Conversation
this isn't an array, it's actually trying to say that the type input is optional (another reason why I think we should just use Julia syntax for that optional argument convention in docstrings) |
Cc @tanmaykm |
I believe we need better standards for documenting optional arguments. In the manual I sometimes see it as
So maybe we need to have that for all optional arguments in the docs, instead of the often ambiguous
|
I think we can merge this. |
it would need a genstdlib run. and it's probably covered by #18041, but worth checking |
@mbeltagy in that PR I was just trying to get as much stuff out of HelpDB as possible, not really overhaul all those docs (although some of that ended up happening). I agree that the square brackets aren't great. Have you run |
A correct run of |
* Removed confusing array of types in readcsv * Restored brackets to `T` in readcsv doc and added clarifying text * genstdlib rst output for docstring change. (cherry picked from commit 22cc7a5)
No description provided.