Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jl_get_specialization signature mismatch #18334

Merged
merged 1 commit into from
Sep 3, 2016
Merged

Fix jl_get_specialization signature mismatch #18334

merged 1 commit into from
Sep 3, 2016

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Sep 2, 2016

Also fix a few other compiler warnings.

The signature mismatch was caught in a LTO build.

Also fix a few other compiler warnings.
@yuyichao
Copy link
Contributor Author

yuyichao commented Sep 2, 2016

Since #18191 (more specifically b0e692a) is (marked for?) backporting, this commit needs to be too.

@tkelman the backport should remove the few changes in codegen.cpp that's changing integer types to suppress -Wsign-compare.

@yuyichao yuyichao merged commit 7126d89 into master Sep 3, 2016
@yuyichao yuyichao deleted the yyc/warnings branch September 3, 2016 18:30
@tkelman
Copy link
Contributor

tkelman commented Sep 6, 2016

@yuyichao
Copy link
Contributor Author

yuyichao commented Sep 6, 2016

Yes. With the declaration moved into julia_internal.h the patch should be correct as long as it compiles without warnings.

tkelman pushed a commit that referenced this pull request Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants