Deprecate vectorized real methods in favor of compact broadcast syntax #18513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you planning to do |
tkelman
reviewed
Sep 15, 2016
| @deprecate real(D::Diagonal) real.(D) | ||
| @deprecate real(M::Bidiagonal) real.(M) | ||
| @deprecate real(M::Tridiagonal) real.(M) | ||
| @deprecate real(M::SymTridiagonal) real.(M) |
There was a problem hiding this comment.
aren't these AbstractArray subtypes?
There was a problem hiding this comment.
Good catch! Those deprecations are redundant, the result of mechanical rather than thoughtful work. Simplifying. Thanks!
My immediate targets are Perhaps I should open an issue tracking devectorization targets / efforts? Thanks! |
This was referenced Sep 17, 2016
|
Closing per discussion in #18495 (comment). Best! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates all (?) remaining vectorized
realmethods (excepting those forSparseVectors, separate PR) in favor of compact broadcast syntax. Ref. #16285, #17302, #18495, and #18512. Best!As with earlier PRs in this series, to work around #18462 I made the
Broadcastmoduleimportrather thanexportbroadcast. Will correct this if / when a better solution for #18462 appears.