RFC: Pair to Pair conversions #18736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Sep 30, 2016
| @@ -21,6 +21,7 @@ B = [true true false] | |||
| @test reverse(Pair(1,2)) == Pair(2,1) | |||
| @test reverse(Pair("13","24")) == Pair("24","13") | |||
| @test typeof(reverse(Pair{String,Int64}("a",1))) == Pair{Int64,String} | |||
| @test convert(Pair{Float64,Float64}, 17 => 4711) == (17 => 4711) | |||
There was a problem hiding this comment.
this should test the element types too
There was a problem hiding this comment.
Using === instead of == will do this.
vchuravy
approved these changes
Sep 30, 2016
stevengj
reviewed
Sep 30, 2016
| @@ -964,6 +964,11 @@ reverse{A,B}(p::Pair{A,B}) = Pair{B,A}(p.second, p.first) | |||
| endof(p::Pair) = 2 | |||
| length(p::Pair) = 2 | |||
|
|
|||
| convert{A,B}(::Type{Pair{A,B}}, x::Pair{A,B}) = x | |||
| function convert{A,B,C,D}(::Type{Pair{A,B}}, x::Pair{C,D}) | |||
There was a problem hiding this comment.
It should be sufficient to declare function convert{A,B}(::Type{Pair{A,B}}, x::Pair) since you don't use C or D
There was a problem hiding this comment.
Fixed, I also added a few additional test to test symmetry between the first and second element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this when trying to convert
Pair{SubString,SubString}intoPair{String,String}.