Add tests for more permissive any/all with non-boolean collections

[fcard]

.

[fcard]

Ah, found it, the change in any/all behavior was from this commit: 06c93ce
For reference!

[tkelman]

so map and comprehensions are fine now?

[fcard]

They don't short-circuit, otherwise yes.

[tkelman]

but calling any or all on the result of a map or comprehension will still short-circuit, right?

[fcard]

Only if the result has eltype == Bool.

function timeit()
  t_any_some = Any[false; trues(10)]
  t_any_many = Any[false; trues(1000000)]
  t_bool = Bool[false; trues(1000000)]

  res = map(all, (t_any_some, t_any_many, t_bool)) #compile
  @time all(t_any_some)
  @time all(t_any_many)
  @time all(t_bool)
  res
end

julia> timeit()
  0.000001 seconds
  0.027037 seconds
  0.000004 seconds
(false,false,false)

[fcard]

Because of #19543, this is no longer valid as it is. What do?

• Re-purpose it to remove the now irrelevant error message?
• Make this only about the tests?
• Just close this and discard the changes?
• Or maybe take the relevant parts there?

[tkelman]

The tests seem worth keeping

[fcard]

Neat, thanks @tkelman!
I will get to work as soon as that's merged (will have to change them a lil' bit to get them working after that)

[fcard]

It is done.

[tkelman]

lgtm, thanks @fcard!