Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make isfile_casesensitive only check case of the basename on Windows #19291

Merged
merged 2 commits into from
Nov 10, 2016

Conversation

stevengj
Copy link
Member

This modifies the Base.isfile_casesensitive function of #13542, which is used to implement a case-sensitive require (for using and import) to only check the case of the basename of the path on Windows. Rationale:

  • This is consistent with what is done on MacOS and in the fallback (readdir-based) routine.

  • This way, the using statement is case-sensitive, but things like LOAD_PATH are not, as one would probably expect on a case-insensitive filesystem. (See also this discussion.)

Also relevant for #18210. cc @malmaud and @jakebolewski.

@test !Base.isfile_casesensitive(lowered_filename)
rm(true_filename)
end
cd(mktempdir()) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use nested do blocks so the mktempdir also gets cleaned up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants