Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparse vectors join the higher order function party #19690

Merged
merged 3 commits into from
Dec 31, 2016
Merged

sparse vectors join the higher order function party #19690

merged 3 commits into from
Dec 31, 2016
+1,125 −1,006

Commits on Dec 30, 2016

  1. Extend generic sparse map[!]/broadcast[!] to sparse vectors and spars… 

    …e vector/matrix combinations.

Extend generic sparse map[!]/broadcast[!] to sparse vectors and sparse vector/matrix combinations. Do so by introducing a common interface to SparseVector and SparseMatrixCSC for the purposes of map[!]/broadcast[!], and rewriting sparse map[!]/broadcast[!] against that interface. Relocate that code to a separate file/module base/sparse/higherorderfns.jl/SparseArrays.HigherOrderFns, loaded after definition of both SparseVector and SparseMatrixCSC.
    @Sacha0
    Sacha0 committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    6bc7775 View commit details
    Browse the repository at this point in the history

  2. Test generic sparse map[!]/broadcast[!] for sparse vectors/matrices. 

    Condense and systematize existing tests for generic sparse map[!]/broadcast[!], and extend to sparse vectors and vector/matrix combinations. Relocate new test code to a separate file test/sparse/higherorderfns.jl corresponding to base/sparse/higherorderfns.jl. (Test/sparse/sparsevector.jl is hypothetically confined to SparseVectors, and test/sparse/sparse.jl mostly dedicated to SparseMatrixCSCs.) Move older tests of sparse broadcast[!] into that new file as well.
    @Sacha0
    Sacha0 committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    913f637 View commit details
    Browse the repository at this point in the history

  3. Mark tests for sparse broadcast shape checks that should be strengthe… 

    …ned [ci skip].
    @Sacha0
    Sacha0 committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    2786db2 View commit details
    Browse the repository at this point in the history