Fix replinit after jn/world #19697
Merged
Fix replinit after jn/world #19697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
force-pushed
the
yyc/replinit
branch
from
5ca36a4 to
c6ded45
Compare
|
Also switched to using |
|
Will merge tomorrow. |
The callback needs to be run in the latest world. Also use `showerror` instead of `show` to display the error.
yuyichao
force-pushed
the
yyc/replinit
branch
from
c6ded45 to
233278a
Compare
|
am hoping a better fix may be possible (https://discourse.julialang.org/t/proposal-for-a-first-class-dispatch-wrapper/1127), but this looks fine for now |
|
At least this is the one used in #17057 and we can always change it later (The uses of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback needs to be run in the latest world.