Deprecate bitbroadcast
#19771
Merged
Deprecate bitbroadcast
#19771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloferz
force-pushed
the
pz/bitbroadcast
branch
from
715ddd4
to
ed30808
Compare
tkelman
reviewed
Dec 30, 2016
| @@ -48,7 +48,7 @@ All mathematical operations and functions are supported for arrays | |||
| ```@docs | |||
| Base.broadcast | |||
| Base.Broadcast.broadcast! | |||
| Base.Broadcast.bitbroadcast | |||
| Base.bitbroadcast | |||
There was a problem hiding this comment.
we should usually delete docs for the old version when we deprecate something
tkelman
reviewed
Dec 30, 2016
| ``` | ||
| """ | ||
| function bitbroadcast end | ||
| @deprecate bitbroadcast broadcast |
There was a problem hiding this comment.
was this also exported from Base? if so, delete it from exports.jl, the deprecate macro handles that
if not, could eval the deprecation into the Broadcast module so the qualified name doesn't change?
Sacha0
approved these changes
Dec 30, 2016
JeffBezanson
pushed a commit
that referenced
this pull request
Dec 31, 2016
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 11, 2017
tkelman
pushed a commit
that referenced
this pull request
May 12, 2017
tkelman
pushed a commit
that referenced
this pull request
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #17623
broadcastproduces aBitArrayinstead ofArray{Bool}for functions yielding a boolean result, sobitbroadcastshouldn't be needed anymore.