WIP: code loading revamp #19866
Closed
WIP: code loading revamp #19866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
force-pushed
the
sk/loadrevamp
branch
from
1160e91
to
c801149
Compare
Closed
StefanKarpinski
force-pushed
the
sk/loadrevamp
branch
3 times, most recently
from
014cee8
to
d543b33
Compare
StefanKarpinski
force-pushed
the
sk/loadrevamp
branch
from
d543b33
to
12f3225
Compare
This was introduced in the 0.6 release cycle, can just be deleted.
StefanKarpinski
force-pushed
the
sk/loadrevamp
branch
from
12f3225
to
f6da260
Compare
|
Issue #19960 can be probably be added as a test case once this is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #19738 – I couldn't figure out how to change a branch name on GitHub. This is a work in progress. To assuage @amitmurthy's fears, my plan is to tear apart the loading code and then build it back better... stronger... faster. It won't actually be faster though. Just saner and easier to extend and configure.