Add show methods for remotes and tags #19955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
display and printing
simonbyrne
requested changes
Jan 11, 2017
| @@ -88,3 +94,5 @@ function push{T<:AbstractString}(rmt::GitRemote, refspecs::Vector{T}; | |||
| !no_refs && close(sa) | |||
| end | |||
| end | |||
|
|
|||
| Base.show(io::IO, rmt::GitRemote) = print(io, "Remote name: ", name(rmt), " url: ", url(rmt)) | |||
There was a problem hiding this comment.
I would suggest printing the name of the type.
kshyatt
force-pushed
the
ksh/showremoteandtag
branch
from
d92ba44 to
8ee9237
Compare
simonbyrne
approved these changes
Jan 11, 2017
tkelman
reviewed
Jan 16, 2017
| @@ -41,3 +41,5 @@ function target(tag::GitTag) | |||
| oid_ptr == C_NULL && throw(Error.GitError(Error.ERROR)) | |||
| return GitHash(oid_ptr) | |||
| end | |||
|
|
|||
| Base.show(io::IO, tag::GitTag) = print(io, "GitTag:\nTag name: $(name(tag)) target: $(target(tag))") | |||
There was a problem hiding this comment.
kinda inconsistent to have one of these use interpolation and the other use multi-arg print
tkelman
reviewed
Jan 16, 2017
|
|
||
| function name(rmt::GitRemote) | ||
| name_ptr = ccall((:git_remote_name, :libgit2), Cstring, (Ptr{Void}, ), rmt.ptr) | ||
| name_ptr == C_NULL && return "" |
There was a problem hiding this comment.
is it valid to have empty-name or empty-url remotes?
There was a problem hiding this comment.
You can have Anonymous remotes, can't you?
There was a problem hiding this comment.
Is that the only thing that can result in getting a null pointer back from this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #19839
Oh, I added a
namefunction forremotesince we didn't have that and it seems useful to know.