Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rowvector tests check for specific exception type #20147

Merged
merged 2 commits into from
Jan 21, 2017
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jan 20, 2017

addresses #19670 (comment), cc @andyferris

and line wrap

@tkelman tkelman added the test This change adds or pertains to unit tests label Jan 20, 2017
@andyferris
Copy link
Member

Thanks Tony. FYI This was already addressed in my follow-up PR #20047 (but I'm happy to rebase on this, especially for the improved formatting)

@tkelman
Copy link
Contributor Author

tkelman commented Jan 20, 2017

whoops, didn't notice, did you add that in the most recent rebase or did I completely miss it earlier?

@andyferris
Copy link
Member

It was last night, so about 18 hours ago, which I think is also the most recent rebase.

@Sacha0
Copy link
Member

Sacha0 commented Jan 21, 2017

@tkelman, would you like review on this pull request, or do you plan to close it in favor of the similar changes in #20047? Best!

@andyferris
Copy link
Member

Merging this first would be fine with me. It looks good to me.

(does a +1 on the OP of a simple PR count as LGTM?)

@tkelman
Copy link
Contributor Author

tkelman commented Jan 21, 2017

okay, if @andyferris doesn't mind rebasing then may as well merge this one now

@tkelman tkelman merged commit 45bc9e2 into master Jan 21, 2017
@tkelman tkelman deleted the tk/rowvector branch January 21, 2017 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants