fix failing subarray test on master (partial linear indexing depwarn) #20242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging faster than usual so fewer currently pending ci runs will fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The at-views PR (#20164) and partial linear indexing deprecation PR (#20079) each last passed CI prior to the other being merged, so CI missed an interaction between them that causes the subarray tests to fail (throwing a depwarn from an at-views test). This pull request disables the offending at-views test, following the approach applied to the equivalent tests for at-view. (Should these instead be
@test_broken? Similar todos exist in the subarray tests regardingColon.) Best!