Miscellaneous tidying, again #20395
Merged
Miscellaneous tidying, again #20395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix plaform typo capitalize first word in doctstring sentences reword NEWS minor rewording in doc/src/manual/arrays.md (see Sacha0 review on PR 20125) there are live cells adjust spacing adjust some indentation in test/parse.jl remove empty line at end of docstring grammar fix in a comment move comma to end of line instead of start of next line reword a little to avoid saying specified twice in rapid succession 4 space indent in const_datatype_getfield_tfunc
omus
approved these changes
Feb 2, 2017
ref e95f5f2 and JuliaLang#7059 and leave a todo note about isdefined and invoke deprecations that are implemented in C
ararslan
reviewed
Feb 2, 2017
| dr2 = [Dates.Date(2000):Dates.Date(2000, 1, 10);] | ||
| dr = ["2000-01-01", "2000-01-02", "2000-01-03", "2000-01-04", "2000-01-05", | ||
| "2000-01-06", "2000-01-07", "2000-01-08", "2000-01-09", "2000-01-10"] | ||
| dr2 = [Dates.Date(2000) : Dates.Date(2000, 1, 10);] |
There was a problem hiding this comment.
Spaces surrounding colons in range expressions I think are fairly atypical. Invenia's JuliaFmt I think actually removes spaces around colons.
There was a problem hiding this comment.
when the index expressions are short yeah, but when they're both long function calls the : sandwiched in the middle doesn't stand out much
|
Pkg failure on appveyor looks like #16555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing especially substantial here, been accumulating trivial fixups on a branch until it felt worth putting a set of them into a PR.