Fix constructors of Symmetric and Hermitian #21622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
commented
Apr 28, 2017
| if A.uplo == char_uplo(uplo) | ||
| return A | ||
| else | ||
| throw(ArgumentError("Cannot construct Symmetric; uplo doesn't match")) |
There was a problem hiding this comment.
Suggestions for better messages here? :)
There was a problem hiding this comment.
why not just ignore the uplo argument? Presumably, if you're building a symmetric matrix from an already symmetric matrix, taking the lower or upper triangle should not matter since they are the same.
There was a problem hiding this comment.
I think it is unlikely that people will hit this exception on purpose, i.e. where they want to flip the storage. We can revisit if it is really an issue.
andreasnoack
approved these changes
Apr 29, 2017
tkelman
reviewed
Apr 29, 2017
| @@ -41,6 +41,15 @@ julia> Slower = Symmetric(A, :L) | |||
| Note that `Supper` will not be equal to `Slower` unless `A` is itself symmetric (e.g. if `A == A.'`). | |||
| """ | |||
| Symmetric(A::AbstractMatrix, uplo::Symbol=:U) = (checksquare(A); Symmetric{eltype(A),typeof(A)}(A, char_uplo(uplo))) | |||
| Symmetric(A::Symmetric) = A | |||
There was a problem hiding this comment.
tiny bit inconsistent that here the default uplo matches that of the input, whereas on all other types it defaults to upper
This was referenced Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21616