document left and right bitshift for BitVector
#21627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! (and thanks Alex for the cleanup) should be squashed on merge |
rfourquet
reviewed
Apr 29, 2017
| Right bit shift operator, `B >> n`. For `n >= 0`, the result is `B` | ||
| with elements shifted `n` positions forward, filling with `false` | ||
| values. If `n < 0`, elements are shifted backwards. Equivalent to | ||
| `B << -n`. |
There was a problem hiding this comment.
I would suggest "If n < 0, this is equivalent to B << -n, i.e. elements are shifted backwards".
There was a problem hiding this comment.
I wrote it this way because if n is positive or negative, B >> n is equivalent to B << -n. Hence the separate statement.
|
Yup good point, I'll add docs for unsigned shift. |
|
Documentation added for |
Sacha0
approved these changes
Apr 29, 2017
|
Thanks! |
|
Thanks for your help everyone. This has been one of my first contributions and you made it a good experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19767 and fixes #20788. Documents
<<and>>for theBitVectortype with examples.