Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cpad functionality to match lpad and rpad #22186

Closed
wants to merge 1 commit into from
Closed

Refactor cpad functionality to match lpad and rpad #22186

wants to merge 1 commit into from

Conversation

djsegal
Copy link

@djsegal djsegal commented Jun 2, 2017

@StefanKarpinski
Copy link
Member

I think that we should not be exporting cpad at all – we should delete it instead. The only use of cpad within base itself is a fairly marginal one to print an error in Pkg, which can be replaced by an inlined version of the appropriate lpad and rpad calls.

@djsegal
Copy link
Author

djsegal commented Jun 5, 2017 •
edited
Loading

Sounds good to me

I just thought it needed to match the other two or get deleted

// as a side reference, this might be an interesting read: how lpad broke the internet

@ararslan ararslan added the strings "Strings!" label Jun 13, 2017
@fredrikekre fredrikekre mentioned this pull request Aug 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djsegal @StefanKarpinski @JeffBezanson @ararslan