Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test elementwise leftshift on BigInt by vector of ints #22524

Merged
merged 1 commit into from
Jun 25, 2017
Merged

test elementwise leftshift on BigInt by vector of ints #22524

merged 1 commit into from
Jun 25, 2017

Conversation

KristofferC
Copy link
Member

Closes #13832

fredrikekre
fredrikekre reviewed Jun 25, 2017
View reviewed changes
test/int.jl
@@ -222,3 +222,5 @@ for T in [Base.BitInteger_types..., BigInt],
U in [Base.BitInteger_types..., BigInt]
@test typeof(rand(U(0):U(127)) % T) === T
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# issue #13832? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@KristofferC KristofferC added backport pending 0.6 test This change adds or pertains to unit tests labels Jun 25, 2017
rfourquet
rfourquet reviewed Jun 25, 2017
View reviewed changes
test/int.jl Outdated
@@ -222,3 +222,6 @@ for T in [Base.BitInteger_types..., BigInt],
U in [Base.BitInteger_types..., BigInt]
@test typeof(rand(U(0):U(127)) % T) === T
end

# issue #13832
@test (BigInt(1) .<< [1:70;])[end] == 1180591620717411303424
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not test also that the array is of type BigInt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@KristofferC KristofferC merged commit 65784d7 into master Jun 25, 2017
@KristofferC KristofferC deleted the kc/test_left_shift branch June 25, 2017 18:14
DrTodd13 pushed a commit to IntelLabs/julia that referenced this pull request Jun 26, 2017
@KristofferC @DrTodd13
test elementwise leftshift on BigInt by vector of ints (JuliaLang#22524)
2fa4aa4
ararslan pushed a commit that referenced this pull request Sep 11, 2017
@KristofferC @ararslan
test elementwise leftshift on BigInt by vector of ints (#22524)
825702c 
Ref #22524
(cherry picked from commit 65784d7)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
@KristofferC @ararslan
test elementwise leftshift on BigInt by vector of ints (#22524)
bff451d 
(cherry picked from commit 65784d7)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
@KristofferC @vtjnash
test elementwise leftshift on BigInt by vector of ints (#22524)
4e3f4b9 
(cherry picked from commit 65784d7)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
@KristofferC @ararslan
test elementwise leftshift on BigInt by vector of ints (#22524)
2a1b86e 
(cherry picked from commit 65784d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfourquet rfourquet rfourquet left review comments

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KristofferC @rfourquet @fredrikekre @ararslan