-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Char * String and Char * Char #22532
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c20972c
added char concat methods
c6dec74
added char concat methods
7ce7e1a
added more tests
7313f5d
condense methods
c377c83
update docstring
f9dd68c
add ...
7d557d2
Minor docstring improvement
ararslan df56a8f
Remove line
ararslan 2fbec25
Merge branch 'master' into char_concat
ararslan a1577a1
Add back the ...
ararslan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,20 +59,21 @@ sizeof(s::AbstractString) = error("type $(typeof(s)) has no canonical binary rep | |
eltype(::Type{<:AbstractString}) = Char | ||
|
||
""" | ||
``` | ||
*(s::AbstractString, t::AbstractString) | ||
``` | ||
*(s::Union{AbstractString, Char}, t::Union{AbstractString, Char}) | ||
|
||
Concatenate strings. The `*` operator is an alias to this function. | ||
|
||
# Example | ||
Concatenate strings and/or characters, producing a [`String`](@ref). This is equivalent | ||
to calling the [`string`](@ref) function on the arguments. | ||
|
||
# Examples | ||
```jldoctest | ||
julia> "Hello " * "world" | ||
"Hello world" | ||
|
||
julia> 'j' * "ulia" | ||
"julia" | ||
``` | ||
""" | ||
(*)(s1::AbstractString, ss::AbstractString...) = string(s1, ss...) | ||
(*)(s1::Union{Char, AbstractString}, ss::Union{Char, AbstractString}...) = string(s1, ss...) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aside from some of the linalg code, typically there isn't a space after the comma in |
||
|
||
one(::Union{T,Type{T}}) where {T<:AbstractString} = convert(T, "") | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why where the three dots removed?