Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for A^p for (secretly) Hermitian and diagonal #23060

Closed
wants to merge 1 commit into from
Closed

Tests for A^p for (secretly) Hermitian and diagonal #23060

wants to merge 1 commit into from

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Jul 31, 2017

A few branches in dense.jl were missed.

@kshyatt kshyatt added linear algebra Linear algebra test This change adds or pertains to unit tests labels Jul 31, 2017
@kshyatt kshyatt requested a review from fredrikekre July 31, 2017 18:34
@kshyatt
Copy link
Contributor Author

kshyatt commented Jul 31, 2017

Should be compatible with #22923

fredrikekre
fredrikekre approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like all the tests from line 551 to 628 could be done with a loop, but doesn't really matter.

@fredrikekre
Copy link
Member

Lets restart CI after #22923 just in case

@fredrikekre fredrikekre closed this Aug 1, 2017
@fredrikekre fredrikekre reopened this Aug 1, 2017
@fredrikekre
Copy link
Member

fredrikekre commented Aug 2, 2017 •
edited
Loading

We are now hitting this:

julia> A = complex.(rand(2,2), rand(2,2));

julia> sqrtm(Symmetric(A))
ERROR: MethodError: no method matching sqrtm(::Symmetric{Complex{Float64},Array{Complex{Float64},2}})

I am confused why we did not hit that code path with the tests in #22923

Edit: Will take a look at this tomorrow

@kshyatt
Copy link
Contributor Author

kshyatt commented Aug 2, 2017

Good call rerunning CI!

@fredrikekre fredrikekre mentioned this pull request Aug 6, 2017
Merged
@fredrikekre
Copy link
Member

superseded by #23158

@fredrikekre fredrikekre closed this Aug 7, 2017
@tkelman tkelman deleted the ksh/genpow branch August 7, 2017 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshyatt @fredrikekre